[core] Fix recompose version #12605
Merged
[core] Fix recompose version #12605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
changed the title
|
"^0.28.0" already includes 0.28.2 |
|
I think the goal is to force a project that has an existing lockfile to bump their recompose version. Maybe package managers already bump transitive dependencies. If this actually resolved in an issue I'd like to see the lockfile. @yamachu You need to update the lockfile. |
|
Yes, most of the fuss with the babel thing comes from recompose not using a fixed version between |
|
@yamachu It's a great first pull request on Material-UI 👌🏻. Thank you for giving it a shot! |
2 tasks
marcelpanse
pushed a commit
to marcelpanse/material-ui
that referenced
this pull request
Oct 2, 2018
* [core] fix recompose version * [icons] fix recompose version * let's merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #12407
and so on.
recompose 2.8.0 and 2.8.1 depend
^@babel/runtime@7.0.0-beta.55,but in 2.8.2, version has been fixed to
@babel/runtime@7.0.0-beta.56acdlite/recompose#724
So, it would be better to change
"recompose": "^0.28.0"torecompose": "^0.28.2"